Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of deprecated pdata Clone methods #6170

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

dmitryax
Copy link
Member

No description provided.

@dmitryax dmitryax requested review from a team and Aneurysm9 September 28, 2022 18:32
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 91.77% // Head: 91.77% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (659ec4f) compared to base (c8871dc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6170   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         218      218           
  Lines       13358    13364    +6     
=======================================
+ Hits        12259    12265    +6     
  Misses        870      870           
  Partials      229      229           
Impacted Files Coverage Δ
pdata/pmetric/pmetricotlp/metrics.go 55.81% <ø> (ø)
service/internal/fanoutconsumer/logs.go 100.00% <100.00%> (ø)
service/internal/fanoutconsumer/metrics.go 100.00% <100.00%> (ø)
service/internal/fanoutconsumer/traces.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the response @dmitryax, LGTM

@codeboten codeboten merged commit 7740c7b into open-telemetry:main Sep 29, 2022
@dmitryax dmitryax deleted the remove-clone-usage branch September 29, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants