More details about trace data in logging exporter #609

pmm-sumo · 2020-03-10T10:39:34Z

Description:

The exporter outputs data in a more verbose format when in debug mode, which allows to easily inspect what spans are being passed using the console.

Additionally, it includes sampling, so by default the console should never get too much data

The logger config is changed to use console encoding

Sample output:

2020-03-13T19:50:09.830Z	INFO	loggingexporter/logging_exporter.go:147	TraceData with 1 spans, node service: frontend, resource "" (1 labels)
Resource labels:
     -> ip: 10.1.1.177
            HostName: hotrod
                 PID: 0
    Library language: LANGUAGE_UNSPECIFIED
Core library version:
    Exporter version: Jaeger-Go-2.15.1dev
Node attributes:
     -> ip: 10.1.1.177
     -> client-uuid: 526d676893250972
	{"exporter": "logging"}
2020-03-13T19:50:09.830Z	DEBUG	loggingexporter/logging_exporter.go:187	Span #0
    Trace ID       : 00000000000000002bb7316b5625e704
    Parent ID      :
    ID             : 2bb7316b5625e704
    Name           : HTTP GET /
    Kind           : SERVER
    Start time     : seconds:1584129009 nanos:56055000
    End time       : seconds:1584129009 nanos:56107000
    Status code    : 0
    Status message :
    Span attributes:
         -> sampler.param: bool_value:true
         -> span.kind: server
         -> http.method: GET
         -> http.url: /
         -> component: net/http
         -> http.status_code: int_value:200
         -> sampler.type: const
	{"exporter": "logging"}

Link to tracking Issue: #610

Testing: Basic unit tests for config and trace data added. Manually tested in an environment with data coming in various formats (Jaeger, Zipkin, OpenCensus)

Documentation: Exporters README updated

tigrannajaryan · 2020-03-10T14:24:37Z

@pmm-sumo thank you for the contribution.

To ensure smoother experience please read https://github.com/open-telemetry/opentelemetry-collector/blob/master/CONTRIBUTING.md

We ask new contributors to create issues and discuss with maintainers first before submitting PRs. This will ensure better experience for everyone, especially in case the suggested feature is not going to be accepted.

This PR looks useful (from the description) and has a good chance to get accepted. I did not have a detailed look since the build fails. Please submit an issue describing the intent and we will take it from there.

codecov-io · 2020-03-10T17:27:56Z

Codecov Report

Merging #609 into master will increase coverage by 0.02%.
The diff coverage is 81.70%.

@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
+ Coverage   75.32%   75.34%   +0.02%     
==========================================
  Files         142      142              
  Lines        9721     9790      +69     
==========================================
+ Hits         7322     7376      +54     
- Misses       2075     2085      +10     
- Partials      324      329       +5

Impacted Files	Coverage Δ
exporter/loggingexporter/logging_exporter.go	`81.70% <78.26%> (-18.30%)`	⬇️
exporter/loggingexporter/factory.go	`67.44% <100.00%> (+4.28%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 275a932...fbc49ac. Read the comment docs.

pmm-sumo · 2020-03-10T18:36:21Z

@pmm-sumo thank you for the contribution.

To ensure smoother experience please read https://github.com/open-telemetry/opentelemetry-collector/blob/master/CONTRIBUTING.md

We ask new contributors to create issues and discuss with maintainers first before submitting PRs. This will ensure better experience for everyone, especially in case the suggested feature is not going to be accepted.

This PR looks useful (from the description) and has a good chance to get accepted. I did not have a detailed look since the build fails. Please submit an issue describing the intent and we will take it from there.

Thank you @tigrannajaryan and apologies for missing the process. I filled the issue as #610

The PR is something I found useful for my purposes and thought it is worth to be shared with the community. It makes several changes to how the logging exporter was working currently and it focuses solely on tracing as of now. If you find it useful, I will be glad to extend it for metrics too or do any other improvements you find helpful

exporter/README.md

exporter/loggingexporter/factory.go

exporter/loggingexporter/logging_exporter.go

testbed/go.sum

The exporter outputs data in a more verbose format, which allows to easily inspect what spans are being passed in the console. Additionally, it includes sampling, so by default the console should never get too much data

Previously, there was only one effect loglevel of logging exporter. Currently, debug is much more verbose and should be used for... debugging. For other purposes, into is sufficient.

tigrannajaryan

LGTM, except please bring back logging of config.Name().

pjanotti

Thanks @pmm-sumo LGTM, just two very nit suggestions and please use the tag "exporter" to log config.Name()

exporter/loggingexporter/config.go

pmm-sumo · 2020-03-13T19:54:22Z

Many thanks @tigrannajaryan and @pjanotti for the review.

I brought back config.Name(). The example of the log output in the PR description was updated.

I was thinking about making similar PR for metrics too, what do you think?

pjanotti

Thanks @pmm-sumo!

pjanotti · 2020-03-13T20:08:30Z

@pmm-sumo

I was thinking about making similar PR for metrics too, what do you think?

That will be nice, just a warning that there are many PRs and we (or perhaps I) may be slow to reply.

tigrannajaryan

Thank you.

* translatesfx: handle SA regex filters SA allows you to specify a regexp filter by wrapping it in forward slashes. This changes detects that and translates it into an expr expression. For example the SA directive: metricsToExclude: - metricName: /vsphere\.cpu_\w*_percent/ should translate into: processors: filter: metrics: exclude: match_type: expr expressions: - MetricName matches "vsphere\\.cpu_\\w*_percent" * translatesfx: don't consider a single '/' a regex filter

pmm-sumo requested review from bogdandrutu, flands, owais, pjanotti, rghetia, songy23 and tigrannajaryan as code owners March 10, 2020 10:39

tigrannajaryan reviewed Mar 11, 2020

View reviewed changes

exporter/README.md Outdated Show resolved Hide resolved

exporter/README.md Outdated Show resolved Hide resolved

exporter/loggingexporter/factory.go Outdated Show resolved Hide resolved

exporter/loggingexporter/factory.go Outdated Show resolved Hide resolved

tigrannajaryan reviewed Mar 11, 2020

View reviewed changes

exporter/loggingexporter/factory.go Outdated Show resolved Hide resolved

tigrannajaryan reviewed Mar 11, 2020

View reviewed changes

pmm-sumo added 6 commits March 13, 2020 13:41

More details about trace data in logging exporter

b598266

The exporter outputs data in a more verbose format, which allows to easily inspect what spans are being passed in the console. Additionally, it includes sampling, so by default the console should never get too much data

Fix imports order

21bb40f

Reduce default logging exporter sampling rate

c750711

E2E tests do not need debug loglevel

b07d99f

Previously, there was only one effect loglevel of logging exporter. Currently, debug is much more verbose and should be used for... debugging. For other purposes, into is sufficient.

Fix formatting issues

18d0ccd

Code cleanup and logging docs clarification

4cb20ef

pmm-sumo force-pushed the logging-exporter branch from ff3199c to 4cb20ef Compare March 13, 2020 12:45

pmm-sumo added 3 commits March 13, 2020 14:06

Tidy testbed go.sum

ba4fe8f

Improve formatting

cb5ddba

Fix type typo

fbc49ac

tigrannajaryan reviewed Mar 13, 2020

View reviewed changes

pjanotti approved these changes Mar 13, 2020

View reviewed changes

exporter/loggingexporter/config.go Outdated Show resolved Hide resolved

exporter/loggingexporter/config.go Outdated Show resolved Hide resolved

Include config.name()

185d077

pjanotti approved these changes Mar 13, 2020

View reviewed changes

tigrannajaryan approved these changes Mar 13, 2020

View reviewed changes

tigrannajaryan merged commit 8693f0f into open-telemetry:master Mar 13, 2020

pmm-sumo mentioned this pull request Jun 6, 2021

REQUEST: New membership for pmm-sumo open-telemetry/community#749

Closed

6 tasks

Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024

Add nuget packaging (open-telemetry#609)

b761ea4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More details about trace data in logging exporter #609

More details about trace data in logging exporter #609

pmm-sumo commented Mar 10, 2020 •

edited

Loading

tigrannajaryan commented Mar 10, 2020 •

edited

Loading

codecov-io commented Mar 10, 2020 •

edited

Loading

pmm-sumo commented Mar 10, 2020

tigrannajaryan left a comment •

edited

Loading

pjanotti left a comment •

edited

Loading

pmm-sumo commented Mar 13, 2020

pjanotti left a comment •

edited

Loading

pjanotti commented Mar 13, 2020

tigrannajaryan left a comment

More details about trace data in logging exporter #609

More details about trace data in logging exporter #609

Conversation

pmm-sumo commented Mar 10, 2020 • edited Loading

tigrannajaryan commented Mar 10, 2020 • edited Loading

codecov-io commented Mar 10, 2020 • edited Loading

Codecov Report

pmm-sumo commented Mar 10, 2020

tigrannajaryan left a comment • edited Loading

Choose a reason for hiding this comment

pjanotti left a comment • edited Loading

Choose a reason for hiding this comment

pmm-sumo commented Mar 13, 2020

pjanotti left a comment • edited Loading

Choose a reason for hiding this comment

pjanotti commented Mar 13, 2020

tigrannajaryan left a comment

Choose a reason for hiding this comment

pmm-sumo commented Mar 10, 2020 •

edited

Loading

tigrannajaryan commented Mar 10, 2020 •

edited

Loading

codecov-io commented Mar 10, 2020 •

edited

Loading

tigrannajaryan left a comment •

edited

Loading

pjanotti left a comment •

edited

Loading

pjanotti left a comment •

edited

Loading