-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pdata] Deprecate FlagsStruct in favor of Flags #5842
Merged
bogdandrutu
merged 6 commits into
open-telemetry:main
from
TylerHelmuth:deprecate-flagsstruct
Aug 5, 2022
Merged
[pdata] Deprecate FlagsStruct in favor of Flags #5842
bogdandrutu
merged 6 commits into
open-telemetry:main
from
TylerHelmuth:deprecate-flagsstruct
Aug 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @bogdandrutu |
Codecov Report
@@ Coverage Diff @@
## main #5842 +/- ##
==========================================
- Coverage 91.82% 91.71% -0.11%
==========================================
Files 196 195 -1
Lines 11920 11932 +12
==========================================
- Hits 10945 10944 -1
- Misses 768 780 +12
- Partials 207 208 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
bogdandrutu
reviewed
Aug 5, 2022
bogdandrutu
approved these changes
Aug 5, 2022
Co-authored-by: Bogdan Drutu <lazy@splunk.com>
Co-authored-by: Bogdan Drutu <lazy@splunk.com>
bogdandrutu
approved these changes
Aug 5, 2022
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Deprecates
FlagsStruct
in favor ofFlags
Link to tracking Issue:
Related to #5443
Testing:
Unit tests