Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate obsreport.[Processor|Exporter]Settings.Level and use MetricsLevel from CreateSettings #5824

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested review from a team and mx-psi August 4, 2022 22:37
…sLevel from CreateSettings

Signed-off-by: Bogdan <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #5824 (719aad1) into main (d7b097c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5824      +/-   ##
==========================================
- Coverage   91.79%   91.79%   -0.01%     
==========================================
  Files         191      191              
  Lines       11479    11474       -5     
==========================================
- Hits        10537    10532       -5     
  Misses        751      751              
  Partials      191      191              
Impacted Files Coverage Δ
obsreport/obsreport_exporter.go 94.33% <ø> (-0.11%) ⬇️
processor/memorylimiterprocessor/memorylimiter.go 88.88% <ø> (-0.06%) ⬇️
exporter/exporterhelper/common.go 93.97% <100.00%> (-0.28%) ⬇️
obsreport/obsreport_processor.go 94.69% <100.00%> (ø)
obsreport/obsreporttest/obsreporttest.go 95.62% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bogdandrutu bogdandrutu merged commit fe226f3 into open-telemetry:main Aug 5, 2022
@bogdandrutu bogdandrutu deleted the deprobsreplevel branch August 5, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants