Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update modules to go 1.18 #5795

Merged

Conversation

codeboten
Copy link
Contributor

Updating to the minimum supported version.

Fixes #5794

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #5795 (43bcf01) into main (a585d0d) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head 43bcf01 differs from pull request most recent head 814dbb2. Consider uploading reports for the commit 814dbb2 to get more accurate results

@@            Coverage Diff             @@
##             main    #5795      +/-   ##
==========================================
- Coverage   91.62%   91.52%   -0.10%     
==========================================
  Files         192      192              
  Lines       11421    11433      +12     
==========================================
  Hits        10464    10464              
- Misses        763      775      +12     
  Partials      194      194              
Impacted Files Coverage Δ
client/client.go 100.00% <ø> (ø)
component/component.go 100.00% <ø> (ø)
component/receiver.go 100.00% <ø> (ø)
config/internal/configsource/manager.go 85.95% <ø> (ø)
confmap/confmap.go 89.47% <ø> (ø)
...nverter/overwritepropertiesconverter/properties.go 100.00% <ø> (ø)
confmap/provider.go 100.00% <ø> (ø)
confmap/provider/fileprovider/provider.go 100.00% <ø> (ø)
confmap/provider/yamlprovider/provider.go 100.00% <ø> (ø)
confmap/resolver.go 92.30% <ø> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bogdandrutu
Copy link
Member

@mx-psi you at one point were against this, did you upgrade your agent?

@mx-psi
Copy link
Member

mx-psi commented Aug 3, 2022

@mx-psi you at one point were against this, did you upgrade your agent?

Not yet, we usually only update to Go 1.N once Go 1.N+1 is released, so we have just gotten started with this. But it should be fine, it just means we will lag behind upstream for a few weeks

Updating to the minimum supported version and removing 1.17 build job.
@codeboten codeboten force-pushed the codeboten/update-go-mod-1.19 branch from 43bcf01 to 814dbb2 Compare August 3, 2022 16:56
@codeboten codeboten marked this pull request as ready for review August 3, 2022 16:56
@codeboten codeboten requested review from a team and bogdandrutu August 3, 2022 16:56
@bogdandrutu bogdandrutu merged commit e07de93 into open-telemetry:main Aug 3, 2022
@codeboten codeboten deleted the codeboten/update-go-mod-1.19 branch June 22, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update minimum go version in go modules
3 participants