Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small nits in confmap tests #5473

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 3, 2022
@bogdandrutu bogdandrutu requested review from a team and mx-psi June 3, 2022 14:11
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #5473 (69fedab) into main (086cc68) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5473      +/-   ##
==========================================
- Coverage   90.84%   90.81%   -0.04%     
==========================================
  Files         193      193              
  Lines       11430    11430              
==========================================
- Hits        10384    10380       -4     
- Misses        824      827       +3     
- Partials      222      223       +1     
Impacted Files Coverage Δ
pdata/internal/common.go 94.61% <0.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 086cc68...69fedab. Read the comment docs.

@codeboten codeboten merged commit 6fb884b into open-telemetry:main Jun 3, 2022
@bogdandrutu bogdandrutu deleted the confmaptests branch June 6, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants