Change config.Retrieved to be an interface #5305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
commented
May 3, 2022
Codecov Report
@@ Coverage Diff @@
## main #5305 +/- ##
==========================================
- Coverage 90.75% 90.56% -0.19%
==========================================
Files 190 190
Lines 11422 11442 +20
==========================================
- Hits 10366 10363 -3
- Misses 837 858 +21
- Partials 219 221 +2
Continue to review full report at Codecov.
|
mx-psi
approved these changes
May 4, 2022
…e values that are not *Map Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
mx-psi
reviewed
May 23, 2022
Comment on lines
+148
to
+151
| // * cfgMap the Map that will be merged to the given map in the MergeTo. | ||
| // * CloseFunc specifies a function to be invoked when the configuration for which it was | ||
| // used to retrieve values is no longer in use and should close and release any watchers | ||
| // that it may have created. |
There was a problem hiding this comment.
docs are out of date here and above
| func (r *valueRetrieved) AsMap() (*Map, error) { | ||
| val, ok := r.value.(map[string]interface{}) | ||
| if !ok { | ||
| return nil, fmt.Errorf("retrieved value (type=%v) cannot be used as a *Map", reflect.TypeOf(r.value)) |
There was a problem hiding this comment.
You can use %T in a format string to get the type
Suggested change
| return nil, fmt.Errorf("retrieved value (type=%v) cannot be used as a *Map", reflect.TypeOf(r.value)) | |
| return nil, fmt.Errorf("retrieved value (type=%T) cannot be used as a *Map", r.value) |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This is outdated at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow to implement support for "retrieving" any type of values, since we can offer implementations of the retrieved for string/etc.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com