Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Create real copy of Value with ValueTypeBytes type #5267

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

dmitryax
Copy link
Member

Fixes #5266

@dmitryax dmitryax requested review from a team and codeboten April 27, 2022 01:13
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #5267 (f47a9e7) into main (b80d754) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5267   +/-   ##
=======================================
  Coverage   90.57%   90.58%           
=======================================
  Files         188      188           
  Lines       11093    11101    +8     
=======================================
+ Hits        10048    10056    +8     
  Misses        824      824           
  Partials      221      221           
Impacted Files Coverage Δ
pdata/internal/common.go 95.01% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b80d754...f47a9e7. Read the comment docs.

@dmitryax dmitryax force-pushed the fix-value-bytes-copy branch from 6274bff to f47a9e7 Compare April 27, 2022 01:18
@codeboten codeboten merged commit f38e3e5 into open-telemetry:main Apr 27, 2022
@dmitryax dmitryax deleted the fix-value-bytes-copy branch May 5, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pdata] Value.CopyTo doesn't copy values of ValueTypeBytes type
3 participants