Fix translation from otlp.Request to pdata representation #5197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52752a9 to
1ca333e
Compare
Codecov Report
@@ Coverage Diff @@
## main #5197 +/- ##
==========================================
+ Coverage 90.35% 90.38% +0.02%
==========================================
Files 188 187 -1
Lines 11055 11087 +32
==========================================
+ Hits 9989 10021 +32
Misses 841 841
Partials 225 225
Continue to review full report at Codecov.
|
f3f16eb to
26f14a0
Compare
The problem that this PR tries to fix, is that changes in the traces object return by the otlp.Request are not reflected in the Request. The solution is to wrap the request proto instead of the data proto, since for the marshalers we don't have an equivalent object that shares the same problem as Request. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
…etry#5197) The problem that this PR tries to fix, is that changes in the traces object return by the otlp.Request are not reflected in the Request. The solution is to wrap the request proto instead of the data proto, since for the marshalers we don't have an equivalent object that shares the same problem as Request. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem that this PR tries to fix, is that changes in the traces object return by the otlp.Request are not reflected in the Request.
The solution is to wrap the request proto instead of the data proto, since for the marshalers we don't have an equivalent object that shares the same problem as Request.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com