Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new yaml provider, allows providing yaml bytes #4998

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Add a new yaml provider, allows providing yaml bytes #4998

merged 1 commit into from
Mar 16, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Mar 14, 2022 •
edited
Loading

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested review from a team and mx-psi March 14, 2022 16:08
@codecov
Copy link

codecov bot commented Mar 14, 2022 •
edited
Loading

Codecov Report

Merging #4998 (77dde78) into main (7666eb0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 77dde78 differs from pull request most recent head 89361c7. Consider uploading reports for the commit 89361c7 to get more accurate results

@@            Coverage Diff             @@
##             main    #4998      +/-   ##
==========================================
+ Coverage   90.91%   90.92%   +0.01%     
==========================================
  Files         182      183       +1     
  Lines       10678    10692      +14     
==========================================
+ Hits         9708     9722      +14     
  Misses        752      752              
  Partials      218      218
Impacted Files Coverage Δ
config/configmapprovider/yaml.go 100.00% <100.00%> (ø)
service/config_provider.go 94.23% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7666eb0...89361c7. Read the comment docs.

mx-psi
mx-psi reviewed Mar 14, 2022
View reviewed changes
config/configmapprovider/bytes_test.go Outdated Show resolved Hide resolved
config/configmapprovider/bytes_test.go Outdated Show resolved Hide resolved
config/configmapprovider/bytes.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu changed the title Add a new bytes provier, allows providing yaml bytes Add a new yaml provider, allows providing yaml bytes Mar 15, 2022
@bogdandrutu bogdandrutu mentioned this pull request Mar 15, 2022
Closed
@bogdandrutu
Add a new bytes provier, allows providing yaml bytes
89361c7 
Open Question: Should the schema be "yaml:" or "bytes:"?

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 07a6238 into open-telemetry:main Mar 16, 2022
@bogdandrutu bogdandrutu deleted the fixnit branch March 16, 2022 07:26
Nicholaswang pushed a commit to Nicholaswang/opentelemetry-collector that referenced this pull request Jun 7, 2022
@bogdandrutu @Nicholaswang
Add a new bytes provier, allows providing yaml bytes (open-telemetry#…
86168d2 
…4998)

Open Question: Should the schema be "yaml:" or "bytes:"?

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling left review comments

@mx-psi mx-psi mx-psi approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bogdandrutu @jpkrohling @Aneurysm9 @mx-psi