Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated Type functions #4933

Merged

Conversation

codeboten
Copy link
Contributor

These have been replaced with ValueType.

These have been replaced with ValueType.
@codeboten codeboten requested review from a team and Aneurysm9 February 28, 2022 23:54
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the pdata changes, based on my experience is better to keep deprecated funcs for 2 releases.

@codeboten
Copy link
Contributor Author

For the pdata changes, based on my experience is better to keep deprecated funcs for 2 releases.

Happy to keep this one opened until the release this week.

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #4933 (d14108c) into main (0c99b50) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4933      +/-   ##
==========================================
- Coverage   91.03%   91.03%   -0.01%     
==========================================
  Files         178      178              
  Lines       10620    10616       -4     
==========================================
- Hits         9668     9664       -4     
  Misses        735      735              
  Partials      217      217              
Impacted Files Coverage Δ
model/pdata/metrics.go 97.91% <ø> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c99b50...d14108c. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 4bde11b into open-telemetry:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants