Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions: mount docker sock for contrib tests #4643

Conversation

rmfitzpatrick
Copy link
Contributor

Description:
Fixing a bug - Adding a docker daemon domain socket volume to the contrib tests container to prevent a failure uncovered by open-telemetry/opentelemetry-collector-contrib@3dfb709.

Example failure: https://github.com/open-telemetry/opentelemetry-collector/runs/4719103326?check_suite_focus=true

Link to tracking Issue:
open-telemetry/opentelemetry-collector-contrib#7023

@rmfitzpatrick rmfitzpatrick requested review from a team and Aneurysm9 January 5, 2022 21:00
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #4643 (673041e) into main (60823e2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4643   +/-   ##
=======================================
  Coverage   90.46%   90.46%           
=======================================
  Files         181      181           
  Lines       10611    10611           
=======================================
  Hits         9599     9599           
  Misses        788      788           
  Partials      224      224           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60823e2...673041e. Read the comment docs.

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 5, 2022
@bogdandrutu
Copy link
Member

@rmfitzpatrick does not seem to fix ...

@rmfitzpatrick
Copy link
Contributor Author

I'm thinking that circleci's setup_remote_docker option adds the container users to the docker group via exec since it has no members by default in cimg/go.

@rmfitzpatrick
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants