Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: Remove deprecated include-core flag #4616

Merged
merged 4 commits into from
Jan 3, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu
Copy link
Member Author

@jpkrohling need to fix tests, but let me know if you are ok with the removal

@jpkrohling
Copy link
Member

jpkrohling commented Jan 3, 2022

let me know if you are ok with the removal

I'm OK with that, we had this deprecated in 0.41.0, we are ready to remove it by 0.42.0. I'll review and manually test this PR soon.

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling
Copy link
Member

need to fix tests

I added a new commit to this PR that should fix the integration tests and a unit test.

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #4616 (fa85de7) into main (3db1d11) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4616      +/-   ##
==========================================
+ Coverage   90.25%   90.34%   +0.09%     
==========================================
  Files         181      181              
  Lines       10595    10573      -22     
==========================================
- Hits         9562     9552      -10     
+ Misses        805      797       -8     
+ Partials      228      224       -4     
Impacted Files Coverage Δ
cmd/builder/internal/builder/config.go 84.50% <ø> (-1.02%) ⬇️
cmd/otelcorecol/components.go 63.63% <100.00%> (+11.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db1d11...fa85de7. Read the comment docs.

jpkrohling and others added 2 commits January 3, 2022 18:19
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants