-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builder: Remove deprecated include-core flag #4616
Conversation
32537cf
to
d55a017
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
d55a017
to
828b288
Compare
@jpkrohling need to fix tests, but let me know if you are ok with the removal |
I'm OK with that, we had this deprecated in 0.41.0, we are ready to remove it by 0.42.0. I'll review and manually test this PR soon. |
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
I added a new commit to this PR that should fix the integration tests and a unit test. |
Codecov Report
@@ Coverage Diff @@
## main #4616 +/- ##
==========================================
+ Coverage 90.25% 90.34% +0.09%
==========================================
Files 181 181
Lines 10595 10573 -22
==========================================
- Hits 9562 9552 -10
+ Misses 805 797 -8
+ Partials 228 224 -4
Continue to review full report at Codecov.
|
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com