Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configtest dependency from collector, generate tests in builder #4607

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Dec 21, 2021

Updates #4605

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested review from a team and Aneurysm9 December 21, 2021 22:18
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #4607 (1d383a2) into main (eb6f051) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4607      +/-   ##
==========================================
- Coverage   90.75%   90.70%   -0.05%     
==========================================
  Files         178      177       -1     
  Lines       10563    10544      -19     
==========================================
- Hits         9586     9564      -22     
- Misses        759      761       +2     
- Partials      218      219       +1     
Impacted Files Coverage Δ
service/collector.go 74.82% <ø> (-0.51%) ⬇️
service/command.go 82.35% <0.00%> (-17.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb6f051...1d383a2. Read the comment docs.

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 21, 2021
@bogdandrutu bogdandrutu merged commit ec90e1f into open-telemetry:main Dec 21, 2021
@bogdandrutu bogdandrutu deleted the rmconfigcheck branch December 22, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants