Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Builder]: Generate test file for config struct check #4594

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Dec 21, 2021

Updates #4605

@bogdandrutu bogdandrutu requested review from a team and jpkrohling December 21, 2021 17:20
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #4594 (5fb64a0) into main (be613cd) will decrease coverage by 0.38%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4594      +/-   ##
==========================================
- Coverage   90.75%   90.36%   -0.39%     
==========================================
  Files         178      181       +3     
  Lines       10566    10621      +55     
==========================================
+ Hits         9589     9598       +9     
- Misses        759      797      +38     
- Partials      218      226       +8     
Impacted Files Coverage Δ
cmd/builder/internal/builder/templates.go 100.00% <ø> (ø)
cmd/builder/internal/builder/main.go 59.74% <77.77%> (-7.29%) ⬇️
cmd/otelcorecol/components.go 52.00% <0.00%> (ø)
cmd/otelcorecol/main_others.go 0.00% <0.00%> (ø)
cmd/otelcorecol/main.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be613cd...5fb64a0. Read the comment docs.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 21, 2021
@bogdandrutu bogdandrutu enabled auto-merge (squash) December 21, 2021 20:38
@bogdandrutu bogdandrutu merged commit 8e1b819 into open-telemetry:main Dec 21, 2021
@bogdandrutu bogdandrutu deleted the addconfigtests branch December 21, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants