Extract client IP address and store it into context for OTLP/HTTP #4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b37de8 to
0cf655b
Compare
0cf655b to
4503eb9
Compare
Codecov Report
@@ Coverage Diff @@
## main #4257 +/- ##
==========================================
+ Coverage 88.22% 88.24% +0.01%
==========================================
Files 173 173
Lines 10320 10332 +12
==========================================
+ Hits 9105 9117 +12
Misses 975 975
Partials 240 240
Continue to review full report at Codecov.
|
I think we would need to extend consumertest.TracesSink (and so on) with keeping the Context to be able to test it, which I wasn't sure if it's a right thing to do. We discussed during the SIG an idea of using additional fields introduced by auth-related code (I think this PR covers them: #3745) If you believe we should add Context to test sinks, I will be happy to do that and add the tests |
bogdandrutu
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes otlphttp receiver so it adds information about the source IP into the context
Context: For k8sattributesprocessor the source IP is frequently required to associate the source with a given pod. This bug is emphasised now since SDK's are now encouraged to switch from gRPC to HTTP
Link to tracking Issue: #4256
Testing: Tested manually. I considered extending unit tests to cover this case, though I believe it would required including Context (as an array or the last one) in
consumertest.TracesSinkand I wasn't sure if it's a right thing to do.Documentation: Not changed