Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pdata to use the newly added [Traces|Metrics|Logs]Data. #4214

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

bogdandrutu
Copy link
Member

The OTLP marshaler/unmarshalers will use the newly added Data messages.

Updates: #4207

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested review from a team and Aneurysm9 October 19, 2021 17:05
The OTLP marshaler/unmarshalers will use the newly added Data messages.

Updates: open-telemetry#4207

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #4214 (6fb19be) into main (f85f13e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4214      +/-   ##
==========================================
- Coverage   87.64%   87.64%   -0.01%     
==========================================
  Files         174      174              
  Lines       10291    10289       -2     
==========================================
- Hits         9020     9018       -2     
  Misses       1018     1018              
  Partials      253      253              
Impacted Files Coverage Δ
model/internal/otlp_wrapper.go 92.02% <100.00%> (ø)
model/otlp/json_unmarshaler.go 76.92% <100.00%> (-1.65%) ⬇️
model/otlp/pb_unmarshaler.go 100.00% <100.00%> (ø)
model/pdata/logs.go 95.83% <100.00%> (ø)
model/pdata/metrics.go 74.07% <100.00%> (ø)
model/pdata/traces.go 94.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f85f13e...6fb19be. Read the comment docs.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bogdandrutu bogdandrutu merged commit 9f2ae4a into open-telemetry:main Oct 19, 2021
@bogdandrutu bogdandrutu deleted the usedata branch October 14, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants