feat: supports more compression methods for configgrpc

[hyunuk]

Description:
This PR ensures that configgrpc supports more compression methods lz4, snappy and zstd, in addition to gzip.
It uses github.com/mostynb/go-grpc-compression, which is a wrapper for compression methods that are not supported by google.golang.org/grpc.

Link to tracking Issue:
#2548

[bogdandrutu]

Title and changelog is wrong since this is only for client side but not for server side as well.

[Aneurysm9]

Title and changelog is wrong since this is only for client side but not for server side as well.

Simply including the additional compression packages makes them available for use by the server through content negotiation. From grpc.RegisterConpression:

will be automatically accessed when receiving a message based on the content coding header. Servers also use it to send a response with the same encoding as the request.

[codecov]

Codecov Report

Merging #4088 (b12782a) into main (cffbecb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4088   +/-   ##
=======================================
  Coverage   88.13%   88.13%           
=======================================
  Files         176      176           
  Lines       10425    10425           
=======================================
  Hits         9188     9188           
  Misses       1005     1005           
  Partials      232      232           

Impacted Files	Coverage Δ
config/configgrpc/configgrpc.go	93.91% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cffbecb...b12782a. Read the comment docs.

[codeboten]

@bogdandrutu any followup items here?

[bogdandrutu]

@codeboten this was discussed last SIG meeting, and it was asked to investigate/create an issue to investigate if the new dependency is the right one, or we should not depend on that third-party module.

[codeboten]

@bogdandrutu ah I see, thanks for clarifying. It seems most other projects (including collector-contrib and jaeger) use the sarama library for the different compression options, should we move this PR in that direction?

Would that be enough to move the PR forward?

[Aneurysm9]

@bogdandrutu ah I see, thanks for clarifying. It seems most other projects (including collector-contrib and jaeger) use the sarama library for the different compression options, should we move this PR in that direction?

Sarama is using the same implementations of zstd and lz4 as the dependency included here. That gives me some confidence in the stability of those implementations and the gRPC compression interface wrapping them is simple and easily reviewed and understood. I don't see a reason to not use this library.

[anuraaga]

@Aneurysm9 I think the main advantage could be more directly controlling the versions of those compression dependencies. zstd seems to be a couple minors behind, not such a big deal probably, but lz4 seems to actually be two majors behind and it's unclear whether that version is supported anymore by the project. Actually, I noticed this useful-looking commit in the latest version from our own @lizthegrey pierrec/lz4@9f82ba4

The simpleness of the gRPC interfaces means on the flip side that implementing here isn't that hard really, but can ensure better that we're on the latest version of these libraries.

[hyunuk]

ah I see, thanks for clarifying. It seems most other projects (including collector-contrib and jaeger) use the sarama library for the different compression options, should we move this PR in that direction?

Would that be enough to move the PR forward?

Sarama is a Go client for Kafka, so all of usage in collector-contrib and jaeger is related to Kafka, not for gRPC configuration.Only kafkareceiver and kafkaexporter is using sarama library in collector-contrib.

To use different compression methods in gRPC, each of them should implement the compressor interface. That's why I'm using a wrapper library in this PR.

[lizthegrey]

Honeycomb upgraded from v2 to v3 of lz4 seamlessly but v4 has breaking changes we weren't ready to take yet.