Add configsource component #2720
Conversation
Create the new component with minimal code addition.
Avoids exposing it from config package.
Codecov Report
@@ Coverage Diff @@
## main #2720 +/- ##
=======================================
Coverage 91.80% 91.80%
=======================================
Files 290 290
Lines 15553 15553
=======================================
Hits 14279 14279
Misses 876 876
Partials 398 398 Continue to review full report at Codecov.
|
|
@pjanotti Do we expect to have one instance of a configsource per collector instance or one instance per config item. For example, given the following config: config_sources:
cfgsrc:
receivers:
$cfgsrc: { key: "rcvr_sub_section" }
exporter:
$cfgsrc: { key: "exp_sub_section" }will the collector create one or two instances of cfgsrc config source. |
|
Reducing the scope of this PR by removing parsing implementation. This way we can focus on the interface of the config sources. |
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package component |
There was a problem hiding this comment.
For the moment I would put everything in configsource package.
|
@pjanotti please update PR description to reflect what is in this PR |
* Add test for custom collectd plugin * fix linting issues * simplify the test to skip if running outside of containers
Why
Adding an internal
ConfigSourcecomponent. This makes the initial exploration of config sources interfaces/usage/implementation possible, related doc.What
Description:
Link to related Issue:
#2469