Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calls to InitEmpty when not necessary, remove AttributeValue.InitEmpty #2225

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

…nitEmpty

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team November 30, 2020 17:00
@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #2225 (7bf5d7e) into master (60eca16) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2225   +/-   ##
=======================================
  Coverage   91.97%   91.98%           
=======================================
  Files         271      271           
  Lines       15657    15664    +7     
=======================================
+ Hits        14401    14408    +7     
  Misses        854      854           
  Partials      402      402           
Impacted Files Coverage Δ
consumer/pdata/common.go 98.86% <ø> (-0.01%) ⬇️
receiver/fluentforwardreceiver/conversion.go 88.44% <ø> (-0.18%) ⬇️
internal/data/spanid.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60eca16...7bf5d7e. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit 7c28105 into open-telemetry:master Nov 30, 2020
@bogdandrutu bogdandrutu deleted the rminitemptyav branch November 30, 2020 17:15
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants