Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README to config components #2072

Merged
merged 8 commits into from
Nov 9, 2020

Conversation

flands
Copy link
Contributor

@flands flands commented Nov 5, 2020

This can be linked to receivers and exporters in a future PR.

This can be linked to receivers and exporters in a future PR.
@flands flands requested a review from a team November 5, 2020 20:26
@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #2072 (6719ce3) into master (5f60c72) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2072      +/-   ##
==========================================
+ Coverage   92.14%   92.15%   +0.01%     
==========================================
  Files         279      279              
  Lines       17082    17082              
==========================================
+ Hits        15740    15742       +2     
+ Misses        922      921       -1     
+ Partials      420      419       -1     
Impacted Files Coverage Δ
translator/internaldata/resource_to_oc.go 91.54% <0.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f60c72...6719ce3. Read the comment docs.

config/configgrpc/README.md Outdated Show resolved Hide resolved
config/confighttp/README.md Outdated Show resolved Hide resolved
config/confighttp/README.md Outdated Show resolved Hide resolved
config/confighttp/README.md Outdated Show resolved Hide resolved
@tigrannajaryan tigrannajaryan self-assigned this Nov 6, 2020
flands and others added 3 commits November 7, 2020 11:46
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
config/confighttp/README.md Outdated Show resolved Hide resolved
@flands
Copy link
Contributor Author

flands commented Nov 7, 2020

@tigrannajaryan all three doc PRs should be ready -- thanks for the reviews.

@bogdandrutu bogdandrutu closed this Nov 9, 2020
@bogdandrutu bogdandrutu reopened this Nov 9, 2020
@tigrannajaryan
Copy link
Member

@flands please fix the conflicts.

@tigrannajaryan
Copy link
Member

@flands build failed, looks like there are broken links.

@bogdandrutu bogdandrutu merged commit ee64e79 into open-telemetry:master Nov 9, 2020
@flands flands deleted the flands/config-readmes branch November 9, 2020 19:51
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants