-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug-level message on error for Jaeger Exporter #1964
Merged
bogdandrutu
merged 1 commit into
open-telemetry:master
from
jpkrohling:jpkrohling/add-debug-message-when-failed-to-send-spans-to-jaeger
Oct 15, 2020
Merged
Add debug-level message on error for Jaeger Exporter #1964
bogdandrutu
merged 1 commit into
open-telemetry:master
from
jpkrohling:jpkrohling/add-debug-message-when-failed-to-send-spans-to-jaeger
Oct 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
October 15, 2020 12:36
bogdandrutu
approved these changes
Oct 15, 2020
jpkrohling
force-pushed
the
jpkrohling/add-debug-message-when-failed-to-send-spans-to-jaeger
branch
from
October 15, 2020 12:57
5711639
to
8c2b8dc
Compare
PR updated. |
Codecov Report
@@ Coverage Diff @@
## master #1964 +/- ##
==========================================
+ Coverage 91.48% 91.49% +0.01%
==========================================
Files 280 280
Lines 16500 16502 +2
==========================================
+ Hits 15095 15099 +4
+ Misses 974 973 -1
+ Partials 431 430 -1
Continue to review full report at Codecov.
|
Those are unrelated, right?
|
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
jpkrohling/add-debug-message-when-failed-to-send-spans-to-jaeger
branch
from
October 15, 2020 19:49
8c2b8dc
to
ef6c7c2
Compare
Rebased, hopefully the contrib-test is fixed by now? |
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de
Important (read before submitting)
Description:
When trying to get the OpenTelemetry Collector to work with Jaeger, it's currently not easy to determine whether a batch has failed to be sent to Jaeger, as there are no logs recorded anywhere.
This PR adds a debug-level message with the error. Users doing an initial setup, or having problems, can enable debug logging and will be able to identify what's wrong.
Example output:
Link to tracking Issue: n/a
Testing: manual test
Documentation: n/a