-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix trace jaeger conversion to internal traces zero time bug #1957
Fix trace jaeger conversion to internal traces zero time bug #1957
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1957 +/- ##
=======================================
Coverage 91.41% 91.41%
=======================================
Files 284 284
Lines 16788 16791 +3
=======================================
+ Hits 15347 15350 +3
Misses 1009 1009
Partials 432 432
Continue to review full report at Codecov.
|
Please add a test to verify the bug fix. |
Well, I think it is better to add function to timestamp package for that and test it there |
@tigrannajaryan does it look good now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Description:
Fixing a bug. When spans are converted from internal trace to jaeger trace the conversion is
zero timestamp -> time.Time{}
which is a reserved date. When converted back, this date is interpreted as a usual one, soProtoBatchesToInternalTraces(InternalTracesToJaegerProto(traces)) != traces
. So I added a check on this one