Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support set flag for component configs (#1640)" #1905

Conversation

tigrannajaryan
Copy link
Member

This reverts commit 450fd93 to ensure
empty objects as component config work.

Temporarily fixes #1897

This reverts commit 450fd93 to ensure
empty objects as component config work.

Temporarily fixes open-telemetry#1897
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #1905 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1905      +/-   ##
==========================================
+ Coverage   91.29%   91.32%   +0.02%     
==========================================
  Files         280      279       -1     
  Lines       16628    16608      -20     
==========================================
- Hits        15181    15167      -14     
+ Misses       1012     1009       -3     
+ Partials      435      432       -3     
Impacted Files Coverage Δ
service/service.go 52.71% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b82e95...14a5f81. Read the comment docs.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tigran

@tigrannajaryan tigrannajaryan merged commit 2efdb28 into open-telemetry:master Oct 5, 2020
@tigrannajaryan tigrannajaryan deleted the feature/tigran/revert-1640 branch October 5, 2020 16:20
@tigrannajaryan
Copy link
Member Author

FYI, @pavolloffay

joe-elliott added a commit to joe-elliott/opentelemetry-collector that referenced this pull request Nov 13, 2020
@pavolloffay pavolloffay mentioned this pull request Nov 19, 2020
joe-elliott added a commit to joe-elliott/opentelemetry-collector that referenced this pull request Nov 30, 2020
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…y#1905)

Bumps [boto3](https://github.com/boto/boto3) from 1.24.56 to 1.24.57.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.24.56...1.24.57)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty objects as component config doesn't work anymore
2 participants