-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update filter processor to use pdata #1885
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1885 +/- ##
==========================================
+ Coverage 91.30% 91.34% +0.03%
==========================================
Files 280 281 +1
Lines 16628 16687 +59
==========================================
+ Hits 15183 15242 +59
Misses 1011 1011
Partials 434 434
Continue to review full report at Codecov.
|
Nice 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good solution for the moment, we should maybe think in the future to add helpers filter[Metrics|Logs|Spans]
in the future that allows to do this in-place.
Updated filter processor to use pdata rather than OC. There's still some OC stuff in filter_processor_test.go, but am hoping that can be updated in a separate change.
Also replaced a benchmark test with a new one. (The previous benchmark test failed with a nil pointer.) The new benchmark test has the following results:
4233112 ns/op before this change
837378 ns/op after this change