Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added disk.pending_operations metric #1409

Conversation

james-bebbington
Copy link
Member

@james-bebbington james-bebbington commented Jul 22, 2020

To avoid future conflicts, this is branched from #1408. Please merge that before reviewing this PR.

Adds disk.pending_operations metric

@james-bebbington james-bebbington force-pushed the disk-pending-ops branch 3 times, most recently from a007b0c to 2f71642 Compare July 22, 2020 04:39
@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #1409 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1409   +/-   ##
=======================================
  Coverage   90.61%   90.62%           
=======================================
  Files         220      220           
  Lines       15679    15708   +29     
=======================================
+ Hits        14208    14235   +27     
- Misses       1059     1060    +1     
- Partials      412      413    +1     
Impacted Files Coverage Δ
...iver/internal/scraper/diskscraper/disk_metadata.go 100.00% <100.00%> (ø)
...nternal/scraper/diskscraper/disk_scraper_others.go 100.00% <100.00%> (ø)
...l/scraper/diskscraper/disk_scraper_others_linux.go 100.00% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 83.72% <0.00%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4046234...41119b3. Read the comment docs.

@james-bebbington
Copy link
Member Author

Close in favour of #1428

MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* fix small typo

* Update propagation.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant