Add Logs to Test Bed #1407
Add Logs to Test Bed #1407
Conversation
|
I still need to make the CircleCI environment include the fluent-bit executable so that the load tests will pass here. |
Codecov Report
@@ Coverage Diff @@
## master #1407 +/- ##
==========================================
- Coverage 91.90% 91.88% -0.02%
==========================================
Files 254 254
Lines 17309 17309
==========================================
- Hits 15907 15905 -2
- Misses 1006 1007 +1
- Partials 396 397 +1
Continue to review full report at Codecov.
|
|
Can you please split this into 2 PRs: 1) adding log data type to OTLP receiver, 2) adding log data type to testbed. |
|
I'll fix contrib after this merges. |
testbed/testbed/senders.go
Outdated
| port int | ||
| } | ||
|
|
||
| // Ensure FileLogWriter implements MetricDataSender. |
There was a problem hiding this comment.
| // Ensure FileLogWriter implements MetricDataSender. | |
| // Ensure FileLogWriter implements LogDataSender. |
testbed/testbed/senders.go
Outdated
| _ = f.file.Sync() | ||
| } | ||
|
|
||
| func (f *FileLogWriter) GenConfigYAMLStr() string { |
There was a problem hiding this comment.
Since FileLogWriter is specifically for fluentforward should we give a more specific name, e.g. FbFileLogWriter?
|
|
||
| service: | ||
| extensions: [pprof] | ||
| extensions: [pprof, %s] |
There was a problem hiding this comment.
Does this work correctly if extensionsList is empty?
There was a problem hiding this comment.
Yes, trailing commas are allowed in yaml lists and result in a list of only pprof and nothing else.
|
The tests failed, not sure if related. |
|
Does |
This includes a simple performance test with 10k log records per second Also make CircleCI have fluent-bit in the test environment.
* remove duplicate checkout * adding changelog
This adds a simple 10k logs per second performance test that currently
passes with a fairly low bar.
This also involves adding support for logs to the otlpreceiver since it
is used to receive the logs by the mock backend.
Also expanding the receiverhelper to supportlog receiver factories.