Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record process physical & virtual memory stats separately #1403

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

james-bebbington
Copy link
Member

@james-bebbington james-bebbington commented Jul 21, 2020

On Linux:

  • Physical usage = Resident set size
  • Virtual usage = Virtual memory size

On Windows:

  • Physical usage = Working set size
  • Virtual usage = Commit size (private virtual memory), aka. Page File Usage

From what I can tell, there is one difference in that Virtual Usage on Windows does not include shared virtual memory whereas on Linux it does, but I think these concepts are similar enough to use the same metric. WDYT @jrcamp?

@james-bebbington james-bebbington changed the title Separate process physical & virtual memory stats Record process physical & virtual memory stats separately Jul 21, 2020
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #1403 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1403   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files         221      221           
  Lines       15816    15825    +9     
=======================================
+ Hits        14341    14350    +9     
  Misses       1061     1061           
  Partials      414      414           
Impacted Files Coverage Δ
...nternal/scraper/processscraper/process_metadata.go 100.00% <100.00%> (ø)
...internal/scraper/processscraper/process_scraper.go 98.38% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcf59b3...97e9d56. Read the comment docs.

@jrcamp jrcamp self-assigned this Jul 21, 2020
@jrcamp
Copy link
Contributor

jrcamp commented Jul 22, 2020

@bogdandrutu please merge

@bogdandrutu bogdandrutu merged commit c4a97db into open-telemetry:master Jul 22, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
Remove duplicate strategy that is causing an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants