Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network interface label to network metrics #1377

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

james-bebbington
Copy link
Member

@james-bebbington james-bebbington commented Jul 16, 2020

Add network interface label to network metrics & added config option to filter by interface name

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #1377 into master will increase coverage by 0.00%.
The diff coverage is 96.87%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1377   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files         218      218           
  Lines       15256    15303   +47     
=======================================
+ Hits        13752    13795   +43     
- Misses       1095     1097    +2     
- Partials      409      411    +2     
Impacted Files Coverage Δ
...nternal/scraper/networkscraper/network_metadata.go 100.00% <ø> (ø)
...internal/scraper/networkscraper/network_scraper.go 98.46% <96.66%> (-1.54%) ⬇️
...eceiver/internal/scraper/networkscraper/factory.go 100.00% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 83.72% <0.00%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71392e5...1815991. Read the comment docs.

@james-bebbington james-bebbington changed the title Add network interface dimension and option to filter by it Add network interface label to network metrics & add option to filter by it Jul 16, 2020
@james-bebbington james-bebbington changed the title Add network interface label to network metrics & add option to filter by it Add network interface label to network metrics Jul 16, 2020
@james-bebbington james-bebbington force-pushed the network-device branch 4 times, most recently from 4c440cf to c0ade97 Compare July 17, 2020 00:56
Copy link
Member

@asuresh4 asuresh4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the one comment.

Could you also update the README with some information about the feature?

@james-bebbington james-bebbington force-pushed the network-device branch 2 times, most recently from 2c9d2c5 to e8d9b12 Compare July 27, 2020 03:17
@james-bebbington
Copy link
Member Author

Updated README

receiver/hostmetricsreceiver/README.md Outdated Show resolved Hide resolved
receiver/hostmetricsreceiver/README.md Show resolved Hide resolved
receiver/hostmetricsreceiver/README.md Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit 69a5ddd into open-telemetry:master Jul 29, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…y#1377)

Bumps [boto3](https://github.com/boto/boto3) from 1.21.21 to 1.21.22.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.21.21...1.21.22)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants