-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network interface label to network metrics #1377
Add network interface label to network metrics #1377
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1377 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 218 218
Lines 15256 15303 +47
=======================================
+ Hits 13752 13795 +43
- Misses 1095 1097 +2
- Partials 409 411 +2
Continue to review full report at Codecov.
|
919a74b
to
591035d
Compare
4c440cf
to
c0ade97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, apart from the one comment.
Could you also update the README with some information about the feature?
receiver/hostmetricsreceiver/internal/scraper/networkscraper/network_metadata.go
Outdated
Show resolved
Hide resolved
2c9d2c5
to
e8d9b12
Compare
e8d9b12
to
4359600
Compare
Updated README |
receiver/hostmetricsreceiver/internal/scraper/networkscraper/config.go
Outdated
Show resolved
Hide resolved
4359600
to
1815991
Compare
…y#1377) Bumps [boto3](https://github.com/boto/boto3) from 1.21.21 to 1.21.22. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.21.21...1.21.22) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Add network interface label to network metrics & added config option to filter by interface name