-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log metric data points in logging exporter #1258
Log metric data points in logging exporter #1258
Conversation
Please fix the lint errors |
Codecov Report
@@ Coverage Diff @@
## master #1258 +/- ##
==========================================
+ Coverage 88.50% 88.60% +0.09%
==========================================
Files 207 207
Lines 14945 15109 +164
==========================================
+ Hits 13227 13387 +160
- Misses 1286 1288 +2
- Partials 432 434 +2
Continue to review full report at Codecov.
|
@bogdandrutu added logging for data point values, fixed lint errors, increased code coverage. |
* Log metric data point labels in logging exporter * Add logging for data point values * Add test case with empty data points
* Add delegating global propagator * Add Changes to CHANGELOG * Add PR number to CHANGELOG * Add tests using new test framework * Revert "Add tests using new test framework" This reverts commit af7ae17436f2bd5e8e120bcbe9d07be904338d08.
* Update the internal global TextMapPropagator Include feedback from a post-merge review of open-telemetry#1258 * Apply feedback * Update api/global/internal/propagator.go Co-authored-by: Steven E. Harris <seh@panix.com> Co-authored-by: Steven E. Harris <seh@panix.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Description:
Log metric data points in logging exporter.
Currently only resource labels are being logged.
Link to tracking Issue: -
Testing: Unit tests + tested manually:
Documentation: -