Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch size metric #1241

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Conversation

pavolloffay
Copy link
Member

Description: <Describe what has changed.

Add batch size metric (units send in a batch). This metric helps us to tune batch processor size.

Link to tracking Issue:

Related to jaegertracing/jaeger#2165 (comment)
Related to #662
Related to https://github.com/open-telemetry/opentelemetry-collector/issues/1139

Testing: < Describe what testing was performed and which tests were added.>

Documentation: < Describe the documentation added.>

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #1241 into master will decrease coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1241      +/-   ##
==========================================
- Coverage   88.61%   88.23%   -0.39%     
==========================================
  Files         207      201       -6     
  Lines       15110    14630     -480     
==========================================
- Hits        13390    12909     -481     
- Misses       1287     1290       +3     
+ Partials      433      431       -2     
Impacted Files Coverage Δ
processor/batchprocessor/batch_processor.go 97.20% <100.00%> (+1.42%) ⬆️
processor/batchprocessor/metrics.go 100.00% <100.00%> (ø)
receiver/hostmetricsreceiver/factory.go 73.58% <0.00%> (-13.52%) ⬇️
...ceiver/hostmetricsreceiver/hostmetrics_receiver.go 73.52% <0.00%> (-11.72%) ⬇️
exporter/loggingexporter/logging_exporter.go 83.68% <0.00%> (-5.49%) ⬇️
receiver/jaegerreceiver/trace_receiver.go 78.34% <0.00%> (-1.66%) ⬇️
receiver/hostmetricsreceiver/internal/testutils.go 88.00% <0.00%> (-1.29%) ⬇️
testutil/testutil.go 91.22% <0.00%> (-0.96%) ⬇️
receiver/otlpreceiver/factory.go 84.84% <0.00%> (-0.66%) ⬇️
receiver/opencensusreceiver/factory.go 95.00% <0.00%> (-0.24%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add8f61...387caba. Read the comment docs.

Copy link
Member

@james-bebbington james-bebbington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay
Copy link
Member Author

Rebased. Could be this merged?

@pavolloffay
Copy link
Member Author

Can somebody restart windows and load tests?

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@bogdandrutu bogdandrutu merged commit 97d9d86 into open-telemetry:master Jul 7, 2020
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
* Add batch size metric to otel collector

Signed-off-by: Pavol Loffay <ploffay@redhat.com>

* Rename variable

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
)

* Move the apitest package into oteltest

* Add documentation to exported func and type

* Add changes to CHANGELOG

* Update move in other modules
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Bumps golang from 1.17.6-stretch to 1.17.7-stretch.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants