Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update queue size after the element is done exported #12399

Merged

Conversation

bogdandrutu
Copy link
Member

This PR changes when the size of the queues is updated, previously the size was updated when the element was removed from the queue but before was fully consumed (done callback was called), after this PR the size is updated when done callback is called.

This change ensures that the queue size limit applies to the whole exporter and allows better memory control for the users.

@bogdandrutu bogdandrutu requested review from a team and dmitryax as code owners February 16, 2025 18:50
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.55%. Comparing base (0831231) to head (63a413c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12399   +/-   ##
=======================================
  Coverage   91.54%   91.55%           
=======================================
  Files         467      467           
  Lines       25623    25652   +29     
=======================================
+ Hits        23456    23485   +29     
  Misses       1768     1768           
  Partials      399      399           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu changed the title Update queue size after the element is exported, ensures limit Update queue size after the element is exported Feb 16, 2025
@bogdandrutu bogdandrutu changed the title Update queue size after the element is exported Update queue size after the element is done exported Feb 16, 2025
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu force-pushed the ensure-queue-size-update branch from ad784e9 to 63a413c Compare February 16, 2025 19:02
@bogdandrutu bogdandrutu added this pull request to the merge queue Feb 17, 2025
Merged via the queue into open-telemetry:main with commit 0d2f646 Feb 17, 2025
55 checks passed
@bogdandrutu bogdandrutu deleted the ensure-queue-size-update branch February 17, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants