[*test] Add NewNopSettingsWithType everywhere #12357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36b6bb5 to
8d363d0
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (84.84%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12357 +/- ##
==========================================
- Coverage 91.55% 91.51% -0.04%
==========================================
Files 467 467
Lines 25615 25623 +8
==========================================
- Hits 23452 23450 -2
- Misses 1764 1774 +10
Partials 399 399 ☔ View full report in Codecov by Sentry. |
b5b75dc to
0daabd9
Compare
0daabd9 to
267dbaa
Compare
bogdandrutu
approved these changes
Feb 13, 2025
Merged
via the queue into
open-telemetry:main
with commit Feb 13, 2025
a4ae175
54 of 55 checks passed
mx-psi
added a commit
to mx-psi/opentelemetry-collector
that referenced
this pull request
Feb 14, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> Creates `NewNopSettingsWithType` function on test modules and deprecates the `NewNopSettings` functions on those modules. Replace all usages of `NewNopSettings` with `NewNopSettingsWithType`. Part of open-telemetry#12305 but applied to all component kinds. #### Link to tracking issue Updates open-telemetry#12221
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 27, 2025
…12381) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> Error out on mismatched type for all component kinds. Same as #12305 but for all component kinds. #### Link to tracking issue Requires #12357 Fixes #12221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates
NewNopSettingsWithTypefunction on test modules and deprecates theNewNopSettingsfunctions on those modules. Replace all usages ofNewNopSettingswithNewNopSettingsWithType.Part of #12305 but applied to all component kinds.
Link to tracking issue
Updates #12221