Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent issues caused by accessing request after calling Send #12281

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Feb 4, 2025

This can happen when items are added to the memory queue and processed by the batcher in the same time with reading the number of items from this code.

Though our queue does not return error and still add the item unless the Context is cancelled, but likely because of a bug that does not work as expected, see #12282

@bogdandrutu bogdandrutu requested review from dmitryax and a team as code owners February 4, 2025 21:15
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (bbe9cb8) to head (bcd902d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12281      +/-   ##
==========================================
+ Coverage   91.27%   91.31%   +0.03%     
==========================================
  Files         466      465       -1     
  Lines       25583    25586       +3     
==========================================
+ Hits        23351    23363      +12     
+ Misses       1816     1806      -10     
- Partials      416      417       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually looking into this particular problem yesterday. Thank you!

@bogdandrutu bogdandrutu added this pull request to the merge queue Feb 4, 2025
Merged via the queue into open-telemetry:main with commit 677b87e Feb 4, 2025
54 checks passed
@bogdandrutu bogdandrutu deleted the fix-concurrent-issue branch February 4, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants