-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement sync disabled queue #12245
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (94.23%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12245 +/- ##
==========================================
+ Coverage 91.31% 91.34% +0.03%
==========================================
Files 465 467 +2
Lines 25586 25753 +167
==========================================
+ Hits 23363 23525 +162
- Misses 1806 1810 +4
- Partials 417 418 +1 ☔ View full report in Codecov by Sentry. |
Please rebase |
17f4a02
to
203823f
Compare
1362ca3
to
bb33a88
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bb33a88
to
a8f57a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1a75a0a
This PR implements a version of a queue that can be used when users want to not have an async behavior and want to block until the request is send by the exporter.
This implementation is only used when batching is enabled, otherwise if both batching and queueing are disabled no queue or batch is configured.
Benchmark results: