Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sync disabled queue #12245

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Feb 2, 2025

This PR implements a version of a queue that can be used when users want to not have an async behavior and want to block until the request is send by the exporter.

This implementation is only used when batching is enabled, otherwise if both batching and queueing are disabled no queue or batch is configured.

Benchmark results:

goos: darwin
goarch: arm64
pkg: go.opentelemetry.io/collector/exporter/exporterqueue
cpu: Apple M2 Max
BenchmarkDisabledQueueOffer
BenchmarkDisabledQueueOffer-12    	 5839711	       187.5 ns/op	      24 B/op	       1 allocs/op

@bogdandrutu bogdandrutu requested review from dmitryax and a team as code owners February 2, 2025 22:25
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 94.23077% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.34%. Comparing base (677b87e) to head (a8f57a8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
exporter/exporterqueue/queue.go 50.00% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (94.23%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12245      +/-   ##
==========================================
+ Coverage   91.31%   91.34%   +0.03%     
==========================================
  Files         465      467       +2     
  Lines       25586    25753     +167     
==========================================
+ Hits        23363    23525     +162     
- Misses       1806     1810       +4     
- Partials      417      418       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax
Copy link
Member

dmitryax commented Feb 3, 2025

Please rebase

@bogdandrutu bogdandrutu force-pushed the disabled-queue branch 9 times, most recently from 1362ca3 to bb33a88 Compare February 4, 2025 22:14
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdandrutu bogdandrutu added this pull request to the merge queue Feb 5, 2025
Merged via the queue into open-telemetry:main with commit 1a75a0a Feb 5, 2025
53 of 54 checks passed
@bogdandrutu bogdandrutu deleted the disabled-queue branch February 5, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants