Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused not_component config for mdatagen #12237

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Remove unused not_component config for mdatagen #12237

merged 1 commit into from
Feb 15, 2025

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested a review from a team as a code owner February 1, 2025 18:53
@bogdandrutu bogdandrutu requested a review from songy23 February 1, 2025 18:53
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.53%. Comparing base (a4ae175) to head (9b5a911).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12237      +/-   ##
==========================================
+ Coverage   91.51%   91.53%   +0.01%     
==========================================
  Files         467      467              
  Lines       25623    25613      -10     
==========================================
- Hits        23450    23445       -5     
+ Misses       1774     1769       -5     
  Partials      399      399

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

songy23
songy23 reviewed Feb 3, 2025
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a changelog?

@bogdandrutu
Remove unused not_component config for mdatagen
9b5a911 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from songy23 February 13, 2025 17:50
@bogdandrutu
Copy link
Member Author

@songy23 PTAL

@bogdandrutu bogdandrutu added this pull request to the merge queue Feb 14, 2025
Merged via the queue into open-telemetry:main with commit 9dd4a5a Feb 15, 2025
55 checks passed
@bogdandrutu bogdandrutu deleted the rm-not-component branch February 15, 2025 00:02
@sourcery-ai sourcery-ai bot mentioned this pull request Feb 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

@songy23 songy23 songy23 approved these changes

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bogdandrutu @jmacd @songy23