-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure unique aliases #12201
Ensure unique aliases #12201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need a changelog?
@songy23 added in latest commit |
what is expected behavior in the following case: it seems we will still have collision in this case. might need to implement a counter for the transformed names, too, if we go with this approach. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12201 +/- ##
=======================================
Coverage 91.84% 91.85%
=======================================
Files 465 465
Lines 25325 25339 +14
=======================================
+ Hits 23261 23275 +14
Misses 1675 1675
Partials 389 389 ☔ View full report in Codecov by Sentry. |
good catch @jackgopack4, addressed in latest commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks for addressing
Are we good to merge this in ? |
Description
This PR ensures that unique aliases are used for modules with same suffix.
Link to tracking issue
Fixes #12162
Testing
Documentation