Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure unique aliases #12201

Merged
merged 6 commits into from
Feb 10, 2025
Merged

Ensure unique aliases #12201

merged 6 commits into from
Feb 10, 2025

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Jan 28, 2025

Description

This PR ensures that unique aliases are used for modules with same suffix.

Link to tracking issue

Fixes #12162

Testing

Documentation

@mackjmr mackjmr requested a review from a team as a code owner January 28, 2025 14:14
@mackjmr mackjmr requested a review from djaglowski January 28, 2025 14:14
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need a changelog?

@mackjmr
Copy link
Member Author

mackjmr commented Jan 28, 2025

@songy23 added in latest commit

@jackgopack4
Copy link
Contributor

what is expected behavior in the following case:
import github.com/org/module
import github.com/org2/module
import github.com/org/module2

it seems we will still have collision in this case.

might need to implement a counter for the transformed names, too, if we go with this approach.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (30b8d53) to head (ab9cd40).
Report is 90 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12201   +/-   ##
=======================================
  Coverage   91.84%   91.85%           
=======================================
  Files         465      465           
  Lines       25325    25339   +14     
=======================================
+ Hits        23261    23275   +14     
  Misses       1675     1675           
  Partials      389      389           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mackjmr
Copy link
Member Author

mackjmr commented Jan 28, 2025

good catch @jackgopack4, addressed in latest commit

Copy link
Contributor

@jackgopack4 jackgopack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks for addressing

@songy23
Copy link
Member

songy23 commented Jan 28, 2025

@mackjmr
Copy link
Member Author

mackjmr commented Feb 5, 2025

Are we good to merge this in ?

@codeboten codeboten added this pull request to the merge queue Feb 10, 2025
Merged via the queue into open-telemetry:main with commit aa333e9 Feb 10, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OCB] Ensure unique aliases for packages with same suffix
6 participants