Allow to tune the read/write buffers for gRPC server #1218
Conversation
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1218 +/- ##
=======================================
Coverage 88.07% 88.07%
=======================================
Files 203 203
Lines 14658 14664 +6
=======================================
+ Hits 12910 12916 +6
Misses 1310 1310
Partials 438 438
Continue to review full report at Codecov.
|
|
|
||
| // The WriteBufferSize for client gRPC. See grpc.ReadBufferSize | ||
| // (https://godoc.org/google.golang.org/grpc#ReadBufferSize). | ||
| ReadBufferSize int `mapstructure:"read_buffer_size"` |
There was a problem hiding this comment.
Does this make any difference? In my similar experiments with WebSockets reading buffers did not make any difference since we are reading in big chunks. But perhaps gRPC is different, it will be interesting to know if increasing this buffer size makes a difference.
There was a problem hiding this comment.
I saw some difference in gRPC on my Mac not as much as on the client but still something.
|
|
||
| // The WriteBufferSize for client gRPC. See grpc.WriteBufferSize | ||
| // (https://godoc.org/google.golang.org/grpc#WriteBufferSize). | ||
| WriteBufferSize int `mapstructure:"write_buffer_size"` |
There was a problem hiding this comment.
This should not matter. We are not sending anything big from our servers, only tiny responses.
There was a problem hiding this comment.
Correct but want to have them to be completed also because it may matter in a pull protocol.
No description provided.