Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][testonly][exporter] Use new{Logs,Metrics,Traces}Request instead of &{logs,metrics,traces}Request{} #12152

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

sfc-gh-sili
Copy link
Contributor

@sfc-gh-sili sfc-gh-sili commented Jan 22, 2025

Description

As part of the effort to cache request size to improve merge splitting performance
(See #12137 and #12136), we want to make sure requests are created from create function instead of getting initialized via struct directly.

  • newLogsRequest instead of &logsRequest{}
  • newMetrcsRequest instead of &metricsRequest{}
  • newTracesRequest instead of &tracesRequest{}

Link to tracking issue

#12137

Testing

Documentation

@sfc-gh-sili sfc-gh-sili requested review from bogdandrutu, dmitryax and a team as code owners January 22, 2025 00:23
@bogdandrutu bogdandrutu enabled auto-merge January 22, 2025 00:26
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.73%. Comparing base (b09a65b) to head (4230ac3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12152   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files         463      463           
  Lines       24819    24819           
=======================================
  Hits        22767    22767           
  Misses       1670     1670           
  Partials      382      382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 22, 2025
Merged via the queue into open-telemetry:main with commit 9757ead Jan 22, 2025
53 checks passed
@sfc-gh-sili sfc-gh-sili deleted the sili-cleanu branch January 31, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants