Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: enable nolintlint #12132

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

mmorel-35
Copy link
Contributor

Description

nolintlint: Reports ill-formed or insufficient nolint directives.

@mmorel-35 mmorel-35 force-pushed the golangci-lint/nolintlint branch from d53fc63 to 5535885 Compare January 20, 2025 19:40
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.71%. Comparing base (52d1414) to head (5535885).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cmd/mdatagen/internal/command.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12132   +/-   ##
=======================================
  Coverage   91.71%   91.71%           
=======================================
  Files         463      463           
  Lines       24803    24803           
=======================================
  Hits        22749    22749           
  Misses       1672     1672           
  Partials      382      382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 marked this pull request as ready for review January 20, 2025 19:51
@mx-psi mx-psi added this pull request to the merge queue Jan 21, 2025
Merged via the queue into open-telemetry:main with commit b6f379f Jan 21, 2025
68 of 71 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/nolintlint branch January 21, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants