[mdatagen] apply fieldalignment to generated code #12121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b54e2a3 to
7b1e4c0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12121 +/- ##
=======================================
Coverage 91.67% 91.67%
=======================================
Files 461 461
Lines 24749 24749
=======================================
Hits 22689 22689
Misses 1678 1678
Partials 382 382 ☔ View full report in Codecov by Sentry. |
songy23
approved these changes
Jan 19, 2025
7b1e4c0 to
9fcc749
Compare
bogdandrutu
approved these changes
Jan 19, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
…by fieldalignment (#12125) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description update other lifecycle generated tests to not be impacted by fieldalignment <!-- Issue number if applicable --> #### Link to tracking issue See #12121 for original PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the generated code so it doesn't get impacted if you run fieldalignment.