Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove fake-request duplicate test code #12113

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested review from dmitryax and a team as code owners January 17, 2025 04:53
@bogdandrutu bogdandrutu force-pushed the rm-duplicate-test branch 2 times, most recently from 5451619 to c60d9b3 Compare January 17, 2025 05:04
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@dmitryax
Copy link
Member

dmitryax commented Jan 19, 2025

The change makes sense to me, but the failing test is probably related to the change. There must be some difference in the fake requests

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu enabled auto-merge January 19, 2025 22:59
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.70%. Comparing base (a3c7d95) to head (4e5bb1d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12113      +/-   ##
==========================================
+ Coverage   91.67%   91.70%   +0.02%     
==========================================
  Files         461      462       +1     
  Lines       24749    24749              
==========================================
+ Hits        22689    22695       +6     
+ Misses       1678     1672       -6     
  Partials      382      382              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 19, 2025
Merged via the queue into open-telemetry:main with commit f07ebc3 Jan 19, 2025
53 checks passed
@bogdandrutu bogdandrutu deleted the rm-duplicate-test branch January 19, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants