[chore] Revert the change in processortest setting creation #12107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is a changelog required? 🤔 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12107 +/- ##
==========================================
+ Coverage 91.65% 91.67% +0.02%
==========================================
Files 461 461
Lines 24685 24749 +64
==========================================
+ Hits 22625 22689 +64
Misses 1678 1678
Partials 382 382 ☔ View full report in Codecov by Sentry. |
|
@zzzk1 yes please |
bogdandrutu
approved these changes
Jan 17, 2025
|
I think you need to also run |
7f38bab to
d60d702
Compare
4785eac to
5103958
Compare
songy23
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert the
nop_processor.NewNopSettingschange, as it is no longer needed.Link to tracking issue
Fixes #11433
Testing
Documentation