Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: enable early-return from revive #12061

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

mmorel-35
Copy link
Contributor

Description

early-return: In Go it is idiomatic to minimize nesting statements, a typical example is to avoid if-then-else constructions.

@mmorel-35 mmorel-35 force-pushed the revive/early-return branch from 4eba585 to b875f6c Compare January 9, 2025 20:51
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the revive/early-return branch from b875f6c to 0c3a2ca Compare January 9, 2025 20:57
@mmorel-35 mmorel-35 marked this pull request as ready for review January 9, 2025 21:08
@mmorel-35 mmorel-35 requested a review from a team as a code owner January 9, 2025 21:08
@mmorel-35 mmorel-35 requested a review from songy23 January 9, 2025 21:08
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.67%. Comparing base (3132112) to head (0c3a2ca).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12061      +/-   ##
==========================================
- Coverage   91.67%   91.67%   -0.01%     
==========================================
  Files         455      455              
  Lines       24038    24036       -2     
==========================================
- Hits        22037    22035       -2     
  Misses       1629     1629              
  Partials      372      372              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Jan 9, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 10, 2025
Merged via the queue into open-telemetry:main with commit 07ed31a Jan 10, 2025
84 of 90 checks passed
@mmorel-35 mmorel-35 deleted the revive/early-return branch January 10, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants