Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Make check-contrib rebuild and reapply tools #11670

Merged
merged 13 commits into from
Nov 21, 2024
Merged

[chore] Make check-contrib rebuild and reapply tools #11670

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
95dbee0
`make check-contrib` regenerates contrib, including mdatagen and builder
jade-guiton-dd Nov 13, 2024
300b9dc
Tidy everything, not just current group (temporary)
jade-guiton-dd Nov 14, 2024
ce90143
Install mdatagen globally for go:generate
jade-guiton-dd Nov 14, 2024
75f80c9
Don't forget to build other tools too
jade-guiton-dd Nov 14, 2024
c504945
`gofmt` is actually functionally required
jade-guiton-dd Nov 14, 2024
04a3e50
Remove ocb re-run (shouldn't matter for tests)
jade-guiton-dd Nov 14, 2024
d5e4321
Remove auto-generation of `go mod edit` commands
jade-guiton-dd Nov 15, 2024
c0ee5f9
Merge branch 'main' into better-check-contrib
jade-guiton-dd Nov 15, 2024
5ff3fc7
Merge branch 'main' into better-check-contrib
jade-guiton-dd Nov 18, 2024
69a3c89
Use improved contrib Makefile
jade-guiton-dd Nov 18, 2024
992df68
Fix partial `make fmt`
jade-guiton-dd Nov 20, 2024
20325f0
Rename `regenerate-contrib` to `generate-contrib`
jade-guiton-dd Nov 20, 2024
a5fb33c
Remove generate skip check
jade-guiton-dd Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Install mdatagen globally for go:generate
  • Loading branch information
@jade-guiton-dd
jade-guiton-dd committed Nov 14, 2024
commit ce9014388c0b1aafc74541c64320ff7cd85576ad
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ check-contrib:
regenerate-contrib:
@echo -e "\nInstalling tools into contrib"
@rm -f $(CONTRIB_PATH)/.tools/mdatagen $(CONTRIB_PATH)/.tools/builder
@pushd cmd/mdatagen && GOBIN=$(CONTRIB_PATH)/.tools $(GOCMD) install . && popd || { echo ">> could not build mdatagen"; exit 1; }
@pushd cmd/mdatagen && $(GOCMD) install . && popd || { echo ">> could not build mdatagen"; exit 1; }
@pushd cmd/builder && GOBIN=$(CONTRIB_PATH)/.tools $(GOCMD) install . && popd || { echo ">> could not build builder"; exit 1; }

@echo -e "\nRegenerating contrib"
Expand Down
Loading