Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Make check-contrib rebuild and reapply tools #11670

Merged
merged 13 commits into from
Nov 21, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Install mdatagen globally for go:generate
  • Loading branch information
jade-guiton-dd committed Nov 14, 2024
commit ce9014388c0b1aafc74541c64320ff7cd85576ad
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ check-contrib:
regenerate-contrib:
@echo -e "\nInstalling tools into contrib"
@rm -f $(CONTRIB_PATH)/.tools/mdatagen $(CONTRIB_PATH)/.tools/builder
@pushd cmd/mdatagen && GOBIN=$(CONTRIB_PATH)/.tools $(GOCMD) install . && popd || { echo ">> could not build mdatagen"; exit 1; }
@pushd cmd/mdatagen && $(GOCMD) install . && popd || { echo ">> could not build mdatagen"; exit 1; }
@pushd cmd/builder && GOBIN=$(CONTRIB_PATH)/.tools $(GOCMD) install . && popd || { echo ">> could not build builder"; exit 1; }

@echo -e "\nRegenerating contrib"
Expand Down
Loading