Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd/mdatagen]: Add feature gates support to metadata-schema.yaml #11466

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[cmd/mdatagen]: Add feature gates support to metadata-schema.yaml #11466

wants to merge 10 commits into from

Conversation

narcis96
Copy link
Contributor

@narcis96 narcis96 commented Oct 16, 2024 •
edited
Loading

Description:
Added feature-gates section to metadata-schema.yaml together with id, description, stage and other required. This information can then be used for code generation, documentation generation and by other consumers of the metadata.yaml file

Link to tracking Issue: #9860

@narcis96 narcis96 requested a review from a team as a code owner October 16, 2024 10:44
@narcis96 narcis96 requested a review from mx-psi October 16, 2024 10:44
mx-psi
mx-psi requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some comments

cmd/mdatagen/internal/loader.go Outdated Show resolved Hide resolved
cmd/mdatagen/internal/loader.go Outdated Show resolved Hide resolved
cmd/mdatagen/internal/loader.go Outdated Show resolved Hide resolved
cmd/mdatagen/internal/loader.go Outdated Show resolved Hide resolved
@narcis96 narcis96 force-pushed the narcis/feature_gates_in_metadata.yaml_file branch from 7514949 to 05ec7bf Compare October 17, 2024 11:38
mx-psi
mx-psi reviewed Oct 17, 2024
View reviewed changes
cmd/mdatagen/internal/loader.go Outdated Show resolved Hide resolved
cmd/mdatagen/internal/loader.go Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.88235% with 15 lines in your changes missing coverage. Please review.

Project coverage is 91.72%. Comparing base (461a355) to head (bb65d15).

Files with missing lines Patch % Lines
cmd/mdatagen/internal/metadata.go 61.29% 11 Missing and 1 partial ⚠️
cmd/mdatagen/internal/command.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11466      +/-   ##
==========================================
- Coverage   91.77%   91.72%   -0.05%     
==========================================
  Files         462      462              
  Lines       24886    24920      +34     
==========================================
+ Hits        22840    22859      +19     
- Misses       1664     1677      +13     
- Partials      382      384       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@narcis96 narcis96 force-pushed the narcis/feature_gates_in_metadata.yaml_file branch 4 times, most recently from 95dc2e8 to 68b465a Compare October 21, 2024 14:48
@narcis96 narcis96 mentioned this pull request Oct 21, 2024
Closed
6 tasks
@narcis96 narcis96 force-pushed the narcis/feature_gates_in_metadata.yaml_file branch 2 times, most recently from 7ffa5a0 to 32f20c5 Compare October 21, 2024 15:54
@narcis96 narcis96 force-pushed the narcis/feature_gates_in_metadata.yaml_file branch 3 times, most recently from b9a675b to 50d5cf3 Compare October 22, 2024 13:50
@mx-psi
Copy link
Member

mx-psi commented Oct 24, 2024

Can you fix the merge conflict? The CI won't run otherwise

@narcis96 narcis96 force-pushed the narcis/feature_gates_in_metadata.yaml_file branch from 27d1ad9 to a482d76 Compare October 24, 2024 08:36
@narcis96
Copy link
Contributor Author

Can you fix the merge conflict? The CI won't run otherwise

done

@narcis96 narcis96 force-pushed the narcis/feature_gates_in_metadata.yaml_file branch 3 times, most recently from 7daa444 to b63861b Compare October 24, 2024 08:51
@narcis96 narcis96 requested a review from mx-psi October 24, 2024 10:39
@narcis96 @mx-psi
Update cmd/mdatagen/internal/sampleprocessor/metadata.yaml
01e73a2 
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
@narcis96 narcis96 force-pushed the narcis/feature_gates_in_metadata.yaml_file branch from b63861b to 01e73a2 Compare October 24, 2024 13:29
@narcis96
Copy link
Contributor Author

@mx-psi PTAL

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 3, 2024
@mx-psi mx-psi removed the Stale label Dec 3, 2024
@narcis96
Copy link
Contributor Author

@mx-psi PTAL

@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Dec 25, 2024
@narcis96
Copy link
Contributor Author

narcis96 commented Jan 9, 2025

@mx-psi PTAL

@narcis96
Copy link
Contributor Author

@mx-psi PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi Awaiting requested review from mx-psi

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@narcis96 @mx-psi