Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add profiles support to OTLP HTTP exporter #11450

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Add profiles support to OTLP HTTP exporter #11450

merged 3 commits into from
Oct 18, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Oct 15, 2024 •
edited
Loading

Description

This uses the profiles internal packages that were implemented in previous PRs to provide profiles support to the OTLP HTTP exporter.

This PR requires #11226✅ to be merged first.

@dmathieu dmathieu force-pushed the profileshttpexporter branch from bb8235c to a7c4aa3 Compare October 15, 2024 08:58
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.12%. Comparing base (388bae7) to head (ed05199).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
exporter/otlphttpexporter/factory.go 80.00% 2 Missing and 2 partials ⚠️
exporter/otlphttpexporter/otlp.go 88.88% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11450      +/-   ##
==========================================
- Coverage   92.14%   92.12%   -0.02%     
==========================================
  Files         433      433              
  Lines       20389    20441      +52     
==========================================
+ Hits        18787    18831      +44     
- Misses       1238     1243       +5     
- Partials      364      367       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu force-pushed the profileshttpexporter branch from a7c4aa3 to 5bf391e Compare October 15, 2024 09:23
@mx-psi
Copy link
Member

mx-psi commented Oct 16, 2024

I merged #11226 :)

@dmathieu dmathieu force-pushed the profileshttpexporter branch from 5bf391e to ed05199 Compare October 16, 2024 11:35
@dmathieu dmathieu marked this pull request as ready for review October 16, 2024 11:35
@dmathieu dmathieu requested a review from a team as a code owner October 16, 2024 11:35
@dmathieu dmathieu requested a review from evan-bradley October 16, 2024 11:35
mx-psi
mx-psi approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @open-telemetry/collector-approvers I will merge this on Friday EU morning unless there are comments before then

@mx-psi mx-psi merged commit f330cfb into open-telemetry:main Oct 18, 2024
49 of 66 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 18, 2024
@dmathieu dmathieu deleted the profileshttpexporter branch October 18, 2024 08:13
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
@dmathieu @djaglowski
Add profiles support to OTLP HTTP exporter (open-telemetry#11450)
7bb27c7 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This uses the profiles internal packages that were implemented in
previous PRs to provide profiles support to the OTLP HTTP exporter.

This PR requires open-telemetry#11226✅  to be merged first.
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
@dmathieu @HongChenTW
Add profiles support to OTLP HTTP exporter (open-telemetry#11450)
098185c 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This uses the profiles internal packages that were implemented in
previous PRs to provide profiles support to the OTLP HTTP exporter.

This PR requires open-telemetry#11226✅  to be merged first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.112.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dmathieu @mx-psi