-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Move back processor definitions, make profile embed processor #11286
[chore] Move back processor definitions, make profile embed processor #11286
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11286 +/- ##
==========================================
- Coverage 91.52% 91.48% -0.05%
==========================================
Files 424 423 -1
Lines 20222 20239 +17
==========================================
+ Hits 18509 18516 +7
- Misses 1329 1339 +10
Partials 384 384 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
773415f
to
ee1ce1b
Compare
processor.WithLogs(createProcessorLogs, component.StabilityLevelDeprecated), | ||
processorprofiles.WithTraces(createProcessorTraces, component.StabilityLevelDevelopment), | ||
processorprofiles.WithMetrics(createProcessorMetrics, component.StabilityLevelAlpha), | ||
processorprofiles.WithLogs(createProcessorLogs, component.StabilityLevelDeprecated), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should rename processorprofiles
to something like expprocessor
without waiting for another new signal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do that later, since is experimental.
…open-telemetry#11286) Same as open-telemetry#11254 but for processor Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
…open-telemetry#11286) Same as open-telemetry#11254 but for processor Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Same as #11254 but for processor