[chore] fix TestProcessTelemetryWithHostProc test #11222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11222 +/- ##
=======================================
Coverage 91.79% 91.80%
=======================================
Files 424 424
Lines 20094 20094
=======================================
+ Hits 18445 18447 +2
+ Misses 1269 1268 -1
+ Partials 380 379 -1 ☔ View full report in Codecov by Sentry. |
|
I'm curious why this test isn't failing here: #11208 |
|
Is it possible that this test is flaky in its current state, because the cpu seconds may sometimes be more than zero for these metrics, but sometimes not? It seems from looking at it that if you want this condition to catch those specific parameters, we should add this change. These are the parameters this test is testing, no? |
|
seems like this test just missed getting updated when the metrics were changed to add an "otelcol_" prefix: |
yurishkuro
approved these changes
Sep 23, 2024
codeboten
approved these changes
Sep 23, 2024
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Sep 24, 2024
#### Description Fixes failing unit test TestProcessTelemetryWithHostProc under service/internal/proctelemetry/process_telemetry_linux_test.go due to incorrect metric name #### Link to tracking issue Fixes [open-telemetry#11221](open-telemetry#11221)
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
#### Description Fixes failing unit test TestProcessTelemetryWithHostProc under service/internal/proctelemetry/process_telemetry_linux_test.go due to incorrect metric name #### Link to tracking issue Fixes [open-telemetry#11221](open-telemetry#11221)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes failing unit test TestProcessTelemetryWithHostProc under service/internal/proctelemetry/process_telemetry_linux_test.go due to incorrect metric name
Link to tracking issue
Fixes #11221
Testing
unit tests
Documentation
none