Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove use of alias types in service/telemetry #11182

Merged
merged 2 commits into from
Sep 20, 2024

Merge branch 'main' into rm-alias

61ddbe6
Select commit
Loading
Failed to load commit list.
Merged

[chore] Remove use of alias types in service/telemetry #11182

Merge branch 'main' into rm-alias
61ddbe6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 19, 2024 in 1s

91.81% (target 90.00%)

View this Pull Request on Codecov

91.81% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 49.18033% with 31 lines in your changes missing coverage. Please review.

Project coverage is 91.81%. Comparing base (1edd311) to head (61ddbe6).

Files with missing lines Patch % Lines
service/telemetry/factory.go 15.38% 22 Missing ⚠️
service/telemetry/factory_impl.go 74.28% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11182   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files         422      422           
  Lines       20002    20002           
=======================================
  Hits        18365    18365           
  Misses       1262     1262           
  Partials      375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.